-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: backport changes to remove the ability to take a fee for each forwarded packet #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
packet-forward-middleware
Label for items related to the packet forward middleware
label
Aug 6, 2024
Not sure which order we want to handle things but we may want to consider #199 Edit: fighting go.mod issues but wanted to push changes before i do some possibly destructive things with my local environment |
this PR here can just bump to 7.6.X & 199 be closed. It was specifically requested by the hub team is all to ensure it was compatible. They are on mainnet with 7.6 no issue |
github-actions
bot
added
the
async-icq
Label for items related to the async-icq module
label
Aug 20, 2024
…n API breaking change)
Reecepbcups
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async-icq
Label for items related to the async-icq module
packet-forward-middleware
Label for items related to the packet forward middleware
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports changes from #202 to the
release/v7
branchAlso upgrades deps to use ibc-go v7.6.0 which will take favor over the changes in #199